[OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns the same compression type twice

[Sergey Bylokhov]

Looks fine.

On 06.10.16 11:19, Jayathirth D V wrote:
> Hi Phil,
>
>
>
> As discussed offline, I have updated test case to include check for
> duplication of compression types for all ImageIO plugins.
>
>
>
> Please review the updated webrev at your convenience :
>
> http://cr.openjdk.java.net/~jdv/6294607/webrev.01/
>
>
>
> Thanks,
>
> Jay
>
>
>
> *From:*Jayathirth D V
> *Sent:* Wednesday, October 05, 2016 12:23 PM
> *To:* Philip Race; 2d-dev
> *Subject:* RE: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns
> the same compression type twice
>
>
>
> Hi Phil,
>
>
>
> I have verified all plugins only GIF has this duplication problem.
>
>
>
> Thanks,
>
> Jay
>
>
>
> *From:*Phil Race
> *Sent:* Tuesday, October 04, 2016 9:54 PM
> *To:* Jayathirth D V; 2d-dev
> *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-6294607: GIFWriter returns
> the same compression type twice
>
>
>
> This seems fine to me. Perhaps the test could be reworked to
> look for any plugin that reports a duplicate compression type ?
> That may be more useful as a test ..
>
> Is this the only plugin that exhibits such duplication ?
>
> -phil.
>
> On 10/04/2016 04:39 AM, Jayathirth D V wrote:
>
>     Hi,
>
>
>
>     Please review the following fix in JDK9 at your convenience:
>
>
>
>     Bug : https://bugs.openjdk.java.net/browse/JDK-6294607
>
>
>
>     Webrev : http://cr.openjdk.java.net/~jdv/6294607/webrev.00/
>     <http://cr.openjdk.java.net/%7Ejdv/6294607/webrev.00/>
>
>
>
>     Issue : When we call ImageWriteParam.getCompressionTypes() for GIF
>     it returns two compression types “LZW” &  “lzw”.
>
>
>
>     Root cause : Basically we support only LZW compression for GIF. In
>     ImageWriteParam, there are many places in specification where we
>     mention about multiple compression types. In case of GIF, since it
>     returns same compression type twice it would be misleading.
>
>
>
>     Solution : Update GIFImageWriter to return only one compression type
>     string.
>
>
>
>     Thanks,
>
>     Jay
>
>
>
>
>


-- 
Best regards, Sergey.