[OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

[Brian Burkhalter]

One could potentially change all the public getters in non-final classes in javax.imageio.plugins.tiff to be final as in

http://cr.openjdk.java.net/~bpb/8165981/webrev.01/

or go even further and additionally refactor TIFFDirectory to be an interface implemented by the internal TIFFIFD class. In the interest of mitigating to an extent the difficulty encountered by any users potentially migrating from the original JAI Image I/O Tools package, I would however be more in favor of keeping the original proposal in this thread

http://cr.openjdk.java.net/~bpb/8165981/webrev.00/

wherein only TIFFField and TIFFImageReadParam are made final.

Thanks,

Brian

On Oct 4, 2016, at 4:13 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> Probably some methods can be made final also (at least setters and getters)?
> because it always a problem when we validate something in the setter(constructor), but the user returns something unspecified from the overriden getter.
> 
> On 03.10.16 22:51, Brian Burkhalter wrote:
>> Good point. I think TIFFIFD needs to be a subclass therefore lets leave
>> TIFFDirectory as is.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20161018/91c4f5ae/attachment.html>