[OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

[Jayathirth D V]

Hi Brian,

 

Thanks for the review.

 

Regards,

Jay

 

From: Brian Burkhalter 
Sent: Friday, September 09, 2016 2:56 AM
To: Philip Race
Cc: Jayathirth D V; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

 

I perused it before and did not notice any problems. Provided all the tests still pass I am OK with it.

 

Brian

 

On Sep 8, 2016, at 1:46 PM, Philip Race <HYPERLINK "mailto:philip.race at oracle.com"philip.race at oracle.com> wrote:





I wondered what happened to that comment.
I am OK with this so long as Brian is OK with the TIFF changes.

On 8/31/16, 11:55 PM, Jayathirth D V wrote:


@Brian : In case of TIFFImageReader, clearAbortRequest() was not called before every read operation, I have added the same. Also I have removed processImageProgress(0.0f) call which I feel is not needed as we have processImageStarted() which will take care of it(Also to maintain callbacks at same intervals as they are in other readers).

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160908/9f69ffa2/attachment.html>