[OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems
Philip Race
philip.race at oracle.com
Mon Sep 26 16:37:12 UTC 2016
Clemens,
The fix seems fine .. is there a possibility to have a regression test?
Perhaps based on the code in the bug ?
-phil.
On 9/26/16, 8:48 AM, Clemens Eisserer wrote:
> Hello,
>
> The cause of JDK-8162591 is Java2D's gradient implementation allowing
> for coordinates to be specified using floating point values, whereas
> XRender is limited to a 16.16 fixed point format - which can therefor
> easily overflow.
>
> This patch checks whether the supplied coordinates can be represented
> by XRenders fixed-point format, falling back to software otherwise.
>
> Please find a fist version of the proposed patch at:
> http://93.83.133.214/8162591/webrev.01/
>
> Thank you in advance and best regards, Clemens
More information about the 2d-dev
mailing list