[OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming
Jim Graham
james.graham at oracle.com
Thu Apr 20 19:30:08 UTC 2017
Hi Laurent,
The implementation looks good, except that the method chaining-style return value seems out of place here. Similar
trimToSize() methods in Collections return void and none of the other methods in this area use the method chaining
paradigm. In the interest of maintaining a common design theme throughout 2D this method should just return void.
...jim
On 4/18/17 11:49 PM, Laurent Bourgès wrote:
> Hi,
>
> Here is a first attempt to propose a Path2D patch (based on JDK10):
> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8078192
>
> Please review the Path2D changes, notably the javadoc (english) and the modified Path2DCopyConstructor test which checks
> all public Path2D methods on concrete classes (Path2D.Float, Path2D.Double, GeneralPath) after calling path.trimToSize()
>
> Cheers,
> Laurent
More information about the 2d-dev
mailing list