[OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

Phil Race philip.race at oracle.com
Fri Feb 10 23:48:51 UTC 2017


Looks good to me.
It used to be a pain keeping several places in sync, hence the single 
util function.
I guess that pre-dated the Apple code and we didn't realise it had its 
own copy ..
So much code ... so little time ...

-phil.

On 02/10/2017 01:07 AM, Dmitry Batrak wrote:
> Hello,
>
> I'd like to propose a fix for JDK-8170552.
>   bug: https://bugs.openjdk.java.net/browse/JDK-8170552
>   webrev: http://cr.openjdk.java.net/~dbatrak/8170552/webrev.00/ 
> <http://cr.openjdk.java.net/%7Edbatrak/8170552/webrev.00/>
>
> I don't have a Committer status, so I'll require a sponsor.
>
> I've proposed this patch earlier via support ticket (it's also 
> attached to JIRA
> issue). It brings the code used to detect complex text when working 
> with system
> fonts on macOS on par with similar code used for other fonts and 
> platforms.
>
> As compared to the previously provided patch, I've also added a test 
> case. It
> depends on specifics of the font being used (Menlo), but I couldn't 
> think of
> another way to create an automated test for this issue.
>
> Best regards,
> Dmitry Batrak




More information about the 2d-dev mailing list