[OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

[Vadim Pakhnushev]

+1

Vadim

On 11/02/2017 16:15, dmitry markov wrote:
> Hi Dmitry,
>
> The fix looks good to me too, but I am not a reviewer. So  you need 
> one more +1 from someone else with reviewer status.
> I will sponsor integration of the fix once it is finally approved.
>
> Thanks,
> Dmitry
> On 11/02/2017 02:48, Phil Race wrote:
>> Looks good to me.
>> It used to be a pain keeping several places in sync, hence the single 
>> util function.
>> I guess that pre-dated the Apple code and we didn't realise it had 
>> its own copy ..
>> So much code ... so little time ...
>>
>> -phil.
>>
>> On 02/10/2017 01:07 AM, Dmitry Batrak wrote:
>>> Hello,
>>>
>>> I'd like to propose a fix for JDK-8170552.
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8170552
>>>   webrev: http://cr.openjdk.java.net/~dbatrak/8170552/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Edbatrak/8170552/webrev.00/>
>>>
>>> I don't have a Committer status, so I'll require a sponsor.
>>>
>>> I've proposed this patch earlier via support ticket (it's also 
>>> attached to JIRA
>>> issue). It brings the code used to detect complex text when working 
>>> with system
>>> fonts on macOS on par with similar code used for other fonts and 
>>> platforms.
>>>
>>> As compared to the previously provided patch, I've also added a test 
>>> case. It
>>> depends on specifics of the font being used (Menlo), but I couldn't 
>>> think of
>>> another way to create an automated test for this issue.
>>>
>>> Best regards,
>>> Dmitry Batrak
>>
>