[OpenJDK 2D-Dev] RFR: 8172813 test/java/awt/font/JNICheck/JNICheck.sh fails on Linux
Sergey Bylokhov
sergey.bylokhov at oracle.com
Wed Jan 18 16:18:00 UTC 2017
Looks fine.
>
> Both yes and no :-), although I think it is fine to add both.
>
> 1140 .. there are no more than 2 cachedirs (1 user + 1 system) so I didn't examine JNI refs in this loop
>
> 1166 .. I was not realistically expecting a "NULL" here so ignored it.
>
> Unlike some of the JNI bugs "call while pending exception" type bugs we've fixed
> these were actual, not hypothetical.
>
> Updated webrev:
>
> http://cr.openjdk.java.net/~prr/8172813.1
>
>
> -phil.
>
>
> On 01/16/2017 09:07 AM, Sergey Bylokhov wrote:
>> Hi, Phil.
>> Should we add DeleteLocalRef in fontpath.c at lines 1140 and 1166, or both were skipped intentionally?
>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8172813
>>> Webrev : http://cr.openjdk.java.net/~prr/8172813/
>>>
>>> - Clear local refs once we are done with them.
>>> - Use grep to filter out from the log unrelated warnings as separately reported here :
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8131136
>>>
>>> -phil.
>
More information about the 2d-dev
mailing list