[OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

[Laurent Bourgès]

Jim or Phil,
Could you handle the CSR process on that patch and then push it in jdk10 ?

I consider that bug finished on my side.

Laurent

Le 8 juil. 2017 10:02, "Laurent Bourgès" <bourges.laurent at gmail.com> a
écrit :

> Phil,
>
> Here are my comments on this CSR to be fixed in openjdk 10; I already
> submitted a patch and the review process happened in may.
>
> Le 3 juil. 2017 7:41 PM, "Phil Race" <philip.race at oracle.com> a écrit :
>
> Laurent,
>
> Investigation has determined that since this was ported over in the "CCC
> migration project",
> due to the way that is set up it can't be assigned to non-Oracle employees.
>
>
> Ok, no problem.
>
>
> It won't affect any new CSRs that are created.
>
> Since the likelihood of any other similar case is extremely low, the
> simplest answer is
> that either Jim or myself will need to own and edit this one on your
> behalf.
>
> Send Jim or myself the changes you would like to make off-line and we'll
> take care of it.
>
>
> Just change the fix version to 10 and the @since javadoc tag as below:
>
>   /**
>     * Trims the capacity of this Path2D instance to its current
>      * size. An application can use this operation to minimize the
>      * storage of a path.
>      *
>      * @since 10
>      */ +    public abstract void trimToSize();
>
> It will match the proposed patch.
>
> Thanks,
> Laurent
>
>
>
>>>> 2017-04-20 23:04 GMT+02:00 Philip Race <philip.race at oracle.com>:
>>>>
>>>>>  You have a capital letter here and I think it must be lower case ..
>>>>>
>>>>>
>>>>> 2499      * @Since 10
>>>>>
>>>>> -phil.
>>>>>
>>>>>
>>>>> On 4/20/17, 1:58 PM, Laurent Bourgès wrote:
>>>>>
>>>>> Hi Phil & Jim,
>>>>>
>>>>> Here is the updated webrev:
>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/
>>>>>
>>>>> Changes:
>>>>> - trimToSize() return void
>>>>> - fixed test + jtreg passed
>>>>>
>>>>> Bye,
>>>>> Laurent
>>>>>
>>>>> 2017-04-20 21:30 GMT+02:00 Jim Graham <james.graham at oracle.com>:
>>>>>
>>>>>> Hi Laurent,
>>>>>>
>>>>>> The implementation looks good, except that the method chaining-style
>>>>>> return value seems out of place here.  Similar trimToSize() methods in
>>>>>> Collections return void and none of the other methods in this area use the
>>>>>> method chaining paradigm.  In the interest of maintaining a common design
>>>>>> theme throughout 2D this method should just return void.
>>>>>>
>>>>>>                         ...jim
>>>>>>
>>>>>>
>>>>>> On 4/18/17 11:49 PM, Laurent Bourgès wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Here is a first attempt to propose a Path2D patch (based on JDK10):
>>>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/
>>>>>>>
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8078192
>>>>>>>
>>>>>>> Please review the Path2D changes, notably the javadoc (english) and
>>>>>>> the modified Path2DCopyConstructor
>>>>>>
>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20170713/d20d62b6/attachment.html>