[OpenJDK 2D-Dev] [9]JDK-6949753:[TEST BUG]: java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop

[Prasanta Sadhukhan]

Test fix look ok. Only thing is, you can call getPrinterJob() once and 
reutilise instead of calling 3 times and probably there is no need of 
creating a functioncreateNewPrintPageSetup() for it (as it calls 1 
method) but it is upto you.

Few comments:

Copyright should have "," after 2017.
I guess createUI() does not have any call that throws exception so no 
need to have try-catch block for createUI().
Also, there is no need to catch PrinterException and rethrow 
RuntimeException, so you can do away with that try-catch.
Also, you can call disposeUI() in passButton and failButton 
actionlistener instead of in main().  Also, there is no need to do 
setVisible(false) in disposeUI(), dispose() will take care of that.
You can throw RuntimeException when test timed out (instead of just 
println and later getting test fail exception) which is different from 
Test Failed RuntimeException.

Regards
Prasanta
On 6/1/2017 5:10 PM, Shashidhara Veerabhadraiah wrote:
> Hi All,
> Please review a fix for a test bug which contained an infinite loop to test the printer setup dialog's margin attributes retention without the manual step procedure.
>
> The issue with PDialogTest.java which tests the printer setup dialog's margin attributes retention by having as infinite loop to keep popping up the dialog without a proper exit. The test does not cover the instruction steps necessary to properly test dialog's margin attributes retention.
>
> The updated test file includes the standard manual test template along with test cases to cover the printer dialog's margin attributes retention feature.
>
> Bug:
> <https://bugs.openjdk.java.net/browse/JDK-6949753>
>
> Webrev:
> <http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_00/>
>
> Note : PrintDialog on Mac does not show page margins and hence this test does not run on Mac.
>
> Thanks and regards,
> Shashi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20170602/6144b1b2/attachment.html>