[OpenJDK 2D-Dev] [9] Review request for 8181192: [macos] javafx.print.PrinterJob.showPrintDialog() hangs on macOS

Anton Litvinov anton.litvinov at oracle.com
Fri Jun 2 12:40:41 UTC 2017


Hello Phil and Sergey,

The new version of the back out fix, which does not remove the 
regression test and adds "@ignore" jtreg tag, is following.

Webrev (the 2nd version): 
http://cr.openjdk.java.net/~alitvinov/8181192/jdk9/webrev.01

Thank you,
Anton

On 6/1/2017 10:09 PM, Sergey Bylokhov wrote:
>> The fix is fine but rather than deleting the test just mark it @ignore
>>
>> .. it can be then updated
>> with a new version of the fix.
> +1
>
>>
>> -phil.
>>
>> On 6/1/17, 11:19 AM, Anton Litvinov wrote:
>>> Hello,
>>>
>>> Could you please review the following fix for the bug.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181192
>>> Webrev:
>> http://cr.openjdk.java.net/~alitvinov/8181192/jdk9/webrev.00
>>> The bug is a showstopper bug consisting in hanging during the call
>> to
>>> "javafx.print.PrinterJob.showPrintDialog(Windows)" method in JavaFX
>>> application. The bug is a regression of the fix for the bug
>> JDK-8167102.
>>> The solution is a direct back out of the fix JDK-8167102, so it is a
>>> reversed version of the patch for JDK-8167102.
>>>
>>> Thank you,
>>> Anton



More information about the 2d-dev mailing list