[OpenJDK 2D-Dev] [11] RFR for JDK-8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Apr 11 22:04:09 UTC 2018


Looks fine.

On 11/04/2018 07:05, Alexey Ivanov wrote:
> Hi,
> 
> Please review the fix for jdk11:
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8201240
> webrev: http://cr.openjdk.java.net/~aivanov/8201240/jdk11/webrev.00/
> 
> 
> BufImgSurfaceData.ICMColorData uses finalize() to dispose of native 
> resources.
> 
> 2D components usually use Java 2D Disposer. It can be used here too, and 
> the now deprecated finalize() can be removed consequently.
> 
> I ran SwingSet2 and Java2Demo.
> When BufImgSurfaceData.ICMColorData objects become unreachable, 
> BufImg_Dispose_ICMColorData gets called and the associated native 
> resources are freed.
> 
> 
> Thank you in advance.
> 
> Regards,
> Alexey


-- 
Best regards, Sergey.


More information about the 2d-dev mailing list