[OpenJDK 2D-Dev] Review request for: JDK-8197499 RepaintManager does not increase double buffer after attaching a device with higher resolution

[Alexey Ushakov]

Thanks for the corrections, Phil. 

> 1) I am not sure why this was sent to 2d-dev .. it is 100% Swing.

Actually I also wasn’t completely sure that it is pure 2d issue but there was some graphics devices stuff involved so I decided to send it here.

> Actually 11 now .. 10 is already in lock down as GA candidate builds are starting.

No problem let’s target it for 11.

Best Regards,
Alexey

> On 14 Feb 2018, at 01:54, Phil Race <philip.race at oracle.com> wrote:
> 
> +1 to the fix but two comments
> 
> 1) I am not sure why this was sent to 2d-dev .. it is 100% Swing.
> 
> 2) > The fix is targeted for openjdk10
> 
> Actually 11 now .. 10 is already in lock down as GA candidate builds are starting.
> 
> -phil.
> 
> On 02/13/2018 02:00 PM, Sergey Bylokhov wrote:
>> Looks fine.
>> Thank you.
>> 
>> On 13/02/2018 05:19, Alexey Ushakov wrote:
>>> Hi Sergey,
>>> 
>>> Thanks for the comments. Here is updated version of the fix:
>>> 
>>> Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.02/
>>> 
>>> Best Regards,
>>> Alexey
>>> 
>>>> On 12 Feb 2018, at 21:29, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>>> 
>>>> Hi, Alexey.
>>>> Two small comments:
>>>> - It looks like that after the fix we will reset the value to "null" even if it was set by the user, for example the user may want to minimize the memory footprint if he knows that application limite the size of the windows.
>>>> - setDoubleBufferMaximumSize includes clearImages() so it can be removed from displayChanged();
>>>> 
>>>> On 12/02/2018 02:12, Alexey Ushakov wrote:
>>>>> Thanks, for the catch, Laurent!
>>>>> I forgot to remove my debug output that I used to detect the problem and verify the fix. It might be useful for reviewers though, so I left the original webrev  as is and added the new one.
>>>>> Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.01/
>>>>> Best Regards,
>>>>> Alexey
>>>>>> On 12 Feb 2018, at 12:14, Laurent Bourgès <bourges.laurent at gmail.com <mailto:bourges.laurent at gmail.com> <mailto:bourges.laurent at gmail.com>> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> I am not an official reviewer.
>>>>>> 
>>>>>> I just noted you left a stdout statement that should be removed or commented out (trace).
>>>>>> 
>>>>>> You fix seems trivial
>>>>>> 
>>>>>> Laurent
>>>>>> 
>>>>>> Le 12 févr. 2018 09:14, "Alexey Ushakov" <alexey.ushakov at jetbrains.com <mailto:alexey.ushakov at jetbrains.com> <mailto:alexey.ushakov at jetbrains.com>> a écrit :
>>>>>> 
>>>>>>   Hello,
>>>>>> 
>>>>>>   Here is the fix of the RepaintManager that adjust maximum double
>>>>>>   buffer size  after changes in the display environment. The fix is
>>>>>>   targeted for openjdk10 but the problem exists in previous
>>>>>>   releases. Please, have a look.
>>>>>> 
>>>>>>   Bug: https://bugs.openjdk.java.net/browse/JDK-8197499
>>>>>>   <https://bugs.openjdk.java.net/browse/JDK-8197499>
>>>>>>   Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.00/
>>>>>>   <http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.00/>
>>>>>> 
>>>>>>   Best Regards,
>>>>>>   Alexey
>>>> 
>>>> 
>>>> -- 
>>>> Best regards, Sergey.
>>> 
>> 
>> 
>