[OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

Fri Jan 5 05:30:56 UTC 2018

Hello Everyone

Good day to you.

Request your time to review the fix for the bug:
JDK-8194489    Incorrect size computation at BandedSampleModel . createDataBuffer

Root Cause:
. The method BandedSampleModel . createDataBuffer does not consider number of banks and band offsets while computing the required memory size.
. As a result, ArrayIndexOutOfBounds exception is thrown when setting pixel values on banded sample models having -
      . Multiple bands of image data stored in multiple banks of DataBuffer with band offsets 
      . Multiple bands of image data stored in single bank of DataBuffer

Solution:
. Appropriate logic has been added to createDataBuffer method.

Other Info:
. All Jtreg test-cases in java/awt/image were run with the build including the fix.
. No regressions were noticed.

Kindly review the changes at your convenience & share your feedback.
Link: http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.00/

Thank you for your time in review
Have a good day

Prahalad N.