[OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

[Prahalad Kumar Narayanan]

Hello Brian

Thank you for your time in review & suggestions.

> BandedSampleModel
> L193-196 and 203-207: In general I think it's better for method-internal comments to use the "//" form instead of the "/*.*/" form.
   My views:
      . I find interspersed use of // and /* */ for multi-line comments in our client libs code.
      . For example: The D3DBlitLoops uses "//" while many parts of Image IO use /* ... */ for multi-line comments.
      . While implementing the fix, I try to maintain uniformity established by the file getting modified.
      . In general, I refer to this guideline- http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html

> BandedSampleModelSizeTest
> Instead of defining the utility methods compareSamples(int[],int[]) and initSamples(int[],int) 
> you might consider simply using j.u.Arrays.equals(int[],int[]) and j.u.Arrays.fill(int[],int), respectively.       
   My views:
      . Thank you for the suggestion. It helped.
      . I 've modified the test code to use Arrays.fill and Arrays.equals methods.

The modified code is now available for review under
Link: http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.01/

Kindly review at your convenience and share your thoughts.

Thank you for your time in review
Have a good day

Prahalad N.


----- Original Message -----
From: Brian Burkhalter 
Sent: Saturday, January 06, 2018 4:22 AM
To: Prahalad Kumar Narayanan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

Hello Prahalad,

On Jan 4, 2018, at 9:30 PM, Prahalad Kumar Narayanan <prahalad.kumar.narayanan at oracle.com> wrote:


Request your time to review the fix for the bug:
JDK-8194489    Incorrect size computation at BandedSampleModel . createDataBuffer

https://bugs.openjdk.java.net/browse/JDK-8194489


Kindly review the changes at your convenience & share your feedback.
Link: http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.00/

In general I think this looks good. A few comments:

BandedSampleModel
L193-196 and 203-207: In general I think it's better for method-internal comments to use the "//" form instead of the "/*.*/" form.

BandedSampleModelSizeTest
Instead of defining the utility methods compareSamples(int[],int[]) and initSamples(int[],int) you might consider simply using j.u.Arrays.equals(int[],int[]) and j.u.Arrays.fill(int[],int), respectively.

Thanks,

Brian