[OpenJDK 2D-Dev] <AWT Dev> [11] Review Request: 8201611 Broken links in java.desktop javadoc

Phil Race philip.race at oracle.com
Thu Jul 5 22:13:00 UTC 2018


Actually .. I've found that Component.java uses a relative link for 
doc-files in all other cases.
I think that you should actually just remove the usage of @docRoot to 
make it consistent.
It is more logical for this case.

-phil.

On 07/02/2018 10:16 AM, Phil Race wrote:
>
> OK, +1
>
> -phil.
>
> On 07/02/2018 10:09 AM, Sergey Bylokhov wrote:
>> On 02/07/2018 09:29, Phil Race wrote:
>>> Not exactly, it was after javadoc was changed under
>>> https://bugs.openjdk.java.net/browse/JDK-8195795
>>
>> So modules are added to the path.
>>
>>> This one seems to be different than the other two .. no mention of 
>>> the module
>>> http://cr.openjdk.java.net/~serb/8201611/webrev.00/src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataNode.java.udiff.html 
>>
>>
>>
>> The html tag <a> was replaced by the direct javadoc link to the java 
>> class.
>>
>>> Why is it correct ?
>>>
>>> -phil.
>>>
>>>
>>> On 07/02/2018 09:11 AM, Sergey Bylokhov wrote:
>>>> Hello.
>>>> Please review the fix for jdk11.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201611
>>>> Webrev: http://cr.openjdk.java.net/~serb/8201611/webrev.00
>>>>
>>>> Some links in the javadoc became broken after modules were added.
>>>>
>>>
>>
>>
>



More information about the 2d-dev mailing list