[OpenJDK 2D-Dev] [11] Review Request: 8198406 Test TestAATMorxFont is unstable

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Mar 8 20:38:20 UTC 2018


On 03/08/2018 12:03 PM, Sergey Bylokhov wrote:

> On 08/03/2018 08:30, Semyon Sadetsky wrote:
>> Please remove redundant platform detection code since this is done in 
>> the jtreg header now.
>
> This check was added for the case when the test will be run in 
> standalone w/o jtreg
That's doesn't make any sense. The w/o jtreg it is run manually and it 
is always known on what is the platform. There may be a need to run the 
test on another platform but this redundant check makes it not possible.
>
>>
>> --Semyon
>>
>>
>> On 03/07/2018 07:32 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk11.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198406
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8198406/webrev.00
>>>
>>> Initially, this test was marked as unstable, because sometimes it 
>>> passed(when invokeLater did not start till the end of the main 
>>> method) or failed when the code in invokeLater thrown an 
>>> HeadlessException.
>>>
>>> In the fix the test is reworked to use BufferedImage instead of 
>>> Frame, so it will work in headful and headless environment.
>>>
>>> Some additional info:
>>> http://mail.openjdk.java.net/pipermail/2d-dev/2018-February/008947.html
>>>
>>
>
>



More information about the 2d-dev mailing list