[OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

[Phil Race]

I prefer the makefile fix, since we don't by policy, make changes to the 
imported libraries.

On Jan 23rd [1] I expressed such a tool-chain specific makefile fix 
would be fine by me.

Toolchain specific means ideally it would look like what Magnus wrote [2]

Although you said GC 5.4.0 would need to be included in the logic.

If it can be shown to affect current / future versions of gcc then it 
could be unqualified.

I think we've just been waiting for a webrev since then ..

-phil.

[1] http://mail.openjdk.java.net/pipermail/2d-dev/2018-January/008855.html
[2] 
http://mail.openjdk.java.net/pipermail/build-dev/2018-January/020695.html

On 03/21/2018 09:53 AM, Adam Farley8 wrote:
> :)
>
> > Hi Adam,
> > 
> > no problem. I'll open a bug and if necessary find a second reviewer. 
> Thanks for fixing, maybe I can stop building with warnings disabled on 
> our s390 machines now.
> > 
> > ..Thomas
> > 
> > > On Wed, Mar 21, 2018 at 5:10 PM, Andrew Leonard 
> <andrew_m_leonard at uk.ibm.com> wrote:
> > > Hi Thomas,
> > > I'm a "contributor", but not a "committer", so not on that list, didn't 
> even know that
> > > list existed! I was sort of assuming since it was a trivial change, 
> and the request was
> > > for a review, i'd chip in...!
> > > Thanks
> > > Andrew
> > 
> > > Andrew Leonard
> > > Java Runtimes Development
> > > IBM Hursley
> > > IBM United Kingdom Ltd
> > > Phone internal: 245913, external: 01962 815913
> > > internet email: andrew_m_leonard at uk.ibm.com
> > 
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with 
> number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20180321/ac43c8bf/attachment.html>