[OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

[Prahalad Kumar Narayanan]

Hello Phil, Sergey and Jay

Thank you for your time in review.

I've incorporated your review suggestions.
In the updated code, ImageWriter gets disposed appropriately.

Kindly review the updated code at your convenience.
Link: http://cr.openjdk.java.net/~pnarayanan/4954348/webrev.01/

Thank you once again
Have a good day

Prahalad N.


-----Original Message-----
From: Philip Race 
Sent: Tuesday, March 27, 2018 2:40 AM
To: Sergey Bylokhov
Cc: Prahalad Kumar Narayanan; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values



On 3/23/18, 11:56 AM, Sergey Bylokhov wrote:
> Hi, Prahalad.
> A few small comments about the test:
>  - Is it possible to test all installed ImageWriterSpi? It seems that 
> the test itself is not a  JPEG plugin specific?

None of the other plugins support thumbnails so they will all return 0 regardless.
So I think that aspect of the test is OK


>  - You will need to dispose the jpgWriter even in case of exception.

Probably should fix that.

Everything else seems fine.

-phil.
>
> On 23/03/2018 01:10, Prahalad Kumar Narayanan wrote:
>> Kindly review the changes at your convenience
>> Link: http://cr.openjdk.java.net/~pnarayanan/4954348/webrev.00
>>
>> Thank you
>> Have a good day
>>
>> Prahalad N.
>>
>
>