[OpenJDK 2D-Dev] [XS] RFR : JDK-8204085: avoid printing uninitialized pointer in java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed May 30 13:51:29 UTC 2018


Looks fine.

On 30/05/2018 06:32, Baesken, Matthias wrote:
> Hi could I please get reviews for this very small change :
> 
> In 
> java.desktop/windows/native/libawt/java2d/windows/GDIWindowSurfaceData.cpp 
> , function GDIWindowSurfaceData_GetComp,
> 
> we might print pointer pData in uninitialized state.
> 
> This occurs in case localObj == NULL , then we would  print pData 
> without initialization.
> 
> The small fix adds initialization to  pData  :
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8204085
> 
> change :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8204085/
> 
> Thanks, Matthias
> 


-- 
Best regards, Sergey.


More information about the 2d-dev mailing list