[OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

[Phil Race]

Looks good to me. Just some nits.

Can we split the long lines like this  ? :-

#define contextAwareMetricsX(vx, vy) \
     (FTFixedToFloat(context->transform.xx) * (vx) - \
      FTFixedToFloat(context->transform.xy) * (vy))

and why "vx" and "vy", not just x and y ?

-phil.

On 11/10/18 8:53 AM, Andrew Brygin wrote:
> Hello,
>
>   could you please review a fix for JDK-8139178.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8139178
> Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/
>
>   The freetype scaler calculates font metrics with a transform
>   applied to the scaler context. We have to revert this transform
>   in order to get correct font metrics.
>
> Thanks,
> Andrew