[OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

[Andrew Brygin]

Hi Phil,

 I have updated the fix according to your comments:

http://cr.openjdk.java.net/~bae/8139178/webrev.01/

> and why "vx" and "vy", not just x and y ?

 "at the time it seemed a good idea” :)

 if I remember correctly, I had local variables 'x' and ‘y' there,
 so I used 'vx' and 'vy' in the macroses in order to avoid conflicts.
 Now of course there is no need for so complex names :)

Thanks,
Andrew

> On Nov 17, 2018, at 12:10 AM, Phil Race <philip.race at oracle.com> wrote:
> 
> Looks good to me. Just some nits.
> 
> Can we split the long lines like this  ? :-
> 
> #define contextAwareMetricsX(vx, vy) \
>     (FTFixedToFloat(context->transform.xx) * (vx) - \
>      FTFixedToFloat(context->transform.xy) * (vy))
> 
> and why "vx" and "vy", not just x and y ?
> 
> -phil.
> 
> On 11/10/18 8:53 AM, Andrew Brygin wrote:
>> Hello,
>> 
>>  could you please review a fix for JDK-8139178.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139178
>> Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/
>> 
>>  The freetype scaler calculates font metrics with a transform
>>  applied to the scaler context. We have to revert this transform
>>  in order to get correct font metrics.
>> 
>> Thanks,
>> Andrew