[OpenJDK 2D-Dev] [8u] RFR 8201801: RTL language (Hebrew) is presented from left to right

[Philip Race]

 > it will break non-macos build as you are checking for CFont in a 
shared class?

Indeed.

And on top of that, the apparent assumption that all Apple platform 
fonts are AAT fonts is wrong.
Even if we agreed with this approach, which needs thought, it should 
only apply to  AAT fonts

 > Also, if it's the issue still exists, then why you are fixing only in 
8u and not in jdk12?

ICU is not in 12 .. or even 11 .. it was removed in 10.

-phil.

On 9/3/18, 3:33 AM, Prasanta Sadhukhan wrote:
>
> Hi Dmitry,
>
> Not going into technicalities of the fix, but it seems it will break 
> non-macos build as you are checking for CFont in a shared class?
> Also, if it's the issue still exists, then why you are fixing only in 
> 8u and not in jdk12?
>
> Regards
> Prasanta
> On 9/3/2018 3:20 PM, Dmitry Markov wrote:
>> Hello,
>>
>> Could you review a fix for jdk8u, please?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8201801
>> webrev: http://cr.openjdk.java.net/~dmarkov/8201801/jdk8u/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Edmarkov/8201801/jdk8u/webrev.00/>
>>
>> Problem description:
>> The fix for 7162125 [1] enabled font tables processing on OSX. 
>> However there is a lack of support for RTL languages in ICU layout 
>> engine. Quote from ICU guide: “…The AAT processing in the 
>> LayoutEngine is relatively basic as it only applies the default 
>> features in left-to-right text. This processing has been tested for 
>> Devanagari text. Since AAT processing is not script-specific, it 
>> might not work for other scripts…”, more details at 
>> http://userguide.icu-project.org/layoutengine
>> As a result all RTL languages on OSX are incorrectly laid out, (i.e. 
>> the letters are reversely presented).
>>
>> Fix:
>> Skip font tables for RTL languages on OSX platform.
>>
>> Thanks,
>> Dmitry
>>
>> [1] - https://bugs.openjdk.java.net/browse/JDK-7162125
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20180903/683e61eb/attachment.html>