[OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

[Phil Race]

On 09/06/2018 12:31 AM, Laurent Bourgès wrote:
> Phil,
> Thanks for your review.
>
> Le jeu. 6 sept. 2018 à 01:39, Philip Race <philip.race at oracle.com 
> <mailto:philip.race at oracle.com>> a écrit :
>
>     This looks good to me.
>     I've run all our automated tests + done some manual testing
>     as well as building on all platforms and reviewing the source changes.
>
>
> Do you have more closed-source tests that could be opened in OpenJDK ?


I ran the closed source tests not because there were critical tests 
there so much
as it would be stupid not to when it is easier than not running them :-)

There are still many client closed source test that could be open 
sourced although
only a tiny fraction might be applicable here. We open source these as 
we find time ..


>
>      >  PS: What is the process to ask for backport to JDK11 updates ?
>
>     If you think this important enough to backport, then this is the
>     process :
>
>     http://openjdk.java.net/projects/jdk-updates/approval.html
>
>
> I fixed these bugs as I was contacted on the Marlin mailing list by an 
> end user testing the migration of its Map viewer app from jdk8 to 
> OpenJDK11.
>
> I made this patch as small as possible that is compatible with OpenJDK 
> 11/12 and is well tested: low risk.
> For 12, I will propose a more important patch later to upgrade to 
> Marlin 0.9.3
>
> As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I think 
> it is worth fixing it in 11 too.
>
> Any other opinion ?

I am fine with it. But it is the 11 updates maintainers who need to approve.

-phil.

>
> PS: I will fix OpenJFX 11/12 soon
>
> Cheers,
> Laurent

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20180906/a715ca9a/attachment.html>