[OpenJDK 2D-Dev] [13] RFR: JDK-8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use

[Alexey Ivanov]

On 29/03/2019 20:35, Sergey Bylokhov wrote:
> But it looks like an overkill to wait 8 minutes for one test, isn't it?

I agree 8 minutes seem too much. However, I admit it might take even 
more time to setup a network printer.

> Probably we can force the less timeout by the 
> "sun.java2d.print.minRefreshTime"?

That's a good option. Unix uses 2 minutes' interval for polling.

We can make minRefreshTime equal to 2 minutes but leave the default 
refresh time of 4 minutes. Does it sound good? This way the time of 
waiting for two refresh cycles would be reduced to 4 minutes only.

> On 29/03/2019 08:28, Alexey Ivanov wrote:
>> Please take a look at the updated webrev where I've removed @ignore 
>> tag from the test:
>> http://cr.openjdk.java.net/~aivanov/8221263/webrev.1/
>>
>> On 29/03/2019 01:09, Philip Race wrote:
>>> Are you looking for a reason other than that the implementation
>>> is set to refresh the printer list every 4 minutes ?
>>
>> Yes, remote printer list is refreshed every 4 minutes on Windows.
>>
>> The reason why I added step 6 is that the user has no way of knowing 
>> when the refresh occurred. The refresh could happen just before the 
>> printer is added. Waiting for another refresh is to prevent false 
>> failures. If the list isn't updated in two refresh cycles, likely it 
>> won't be updated. In this case, the user will click Fail.
>>
>> Regards,
>> Alexey
>>
>>>
>>> -phil.
>>>
>>>
>>> On 3/28/19, 5:52 PM, Sergey Bylokhov wrote:
>>>> Hi, Alexey.
>>>>
>>>> I think it is ok to drop @ignore tag, but I wonder why did you add 
>>>> the step6 to the instruction.
>>>> 197                     +          "updated.\n"
>>>> 198                     + "Step 6: If the list is not updated, wait 
>>>> for another "
>>>> 199                     +          "4 minutes, and then click 
>>>> Refresh again.\n"
>>>>
>>>> <SNIP>
-- 
Regards,
Alexey