[OpenJDK 2D-Dev] [13] Review Request: 8222917 GraphicsEnvironment for Unix still have an unused dependency on Solaris

[Phil Race]

On 4/24/19 12:35 AM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222917
> Fix: http://cr.openjdk.java.net/~serb/8222917/webrev.00
>
> The SunGraphicsEnvironment has a codepath for the OpenSolaris, but in 
> fact results on this execution is never used.
> This code was added in JDK-6378099:
> http://hg.openjdk.java.net/jdk/client/rev/c3e81f0acd3d#l5.7
> But the usage of isOpenSolaris flag was dropped in JDK-6795908:
> http://hg.openjdk.java.net/jdk/client/rev/be186a33df9b#l45.717

That refactoring caused a lot of fall out. I don't know how much it mattered
since OpenSolaris didn't get deployed a lot, SFAIK. And it was a moving 
target.
I am sure it is fine to remove this now

>
> In this fix, the unused code was removed.
>
> BTW I am not sure why we set the default font for SG2D in the 
> constructor of SunGraphicsEnvironment and not assign the field 
> directly? Probably the reason is related to some cyclic dependency?.
>

I am not sure. Too long ago. BTW did you intend to remove the comment 
ahead of that assignment ?

-phil