[OpenJDK 2D-Dev] [14] RFR JDK-8234398: Replace ID2D1Factory::GetDesktopDpi with GetDeviceCaps

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Dec 2 05:54:17 UTC 2019


Looks fine.

On 11/28/19 10:13 am, Alexey Ivanov wrote:
> Hello,
> 
> Please review the following fix which removes the use of ID2D1Factory::GetDesktopDpi API which is deprecated in VS2019.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234398
> Webrev: http://cr.openjdk.java.net/~aivanov/8234398/webrev.00/
> 
> I have tested the new code on Windows 7 and 8.0, GetDeviceCaps returns the same value as ID2D1Factory::GetDesktopDpi. Java app UI scales up as expected.
> 
> On Windows 8.1 and 10, ID2D1Factory::GetDesktopDpi is used; no changes.
> 
> 
> This fix completely removes dependency on Direct2D.
> 


-- 
Best regards, Sergey.


More information about the 2d-dev mailing list