[OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism
Phil Race
philip.race at oracle.com
Mon Dec 23 18:24:05 UTC 2019
I assume you've run all the regression tests on macos just to make sure ?
Approved if the answer is yes. Approved for 15 that is .. not 14.
-phil.
On 12/6/19 4:23 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 14.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8235520
> Fix: http://cr.openjdk.java.net/~serb/8235520/webrev.00
>
> This is a part of the effort to clean up the macOS code,
> each new cleanup opens a new opportunity to delete some other code.
>
> During the early stage of MacOSXPort development in Java2D we
> use NSView-based OpenGL rendering, which later was replaced by
> the CAopenGLLayer. We can delete this code.
>
> The change is straightforward, it is started at LWCToolkit.java
> where the "sun.awt.disableCALayers" property was deleted and ended at
> CGLSurfaceData.java where CGLWindowSurfaceData was deleted.
>
> Note that I have dropped one JNI native methods which became unused,
> but did not change other native methods, because they touch to the
> shared code, I will do it later.
>
>
> mach5 is green.
>
More information about the 2d-dev
mailing list