[OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

[Alexey Ivanov]

Hi Phil,

On 11/02/2019 18:32, Phil Race wrote:
>
> On 2/11/19 1:44 AM, Alexey Ivanov wrote:
>> Hi Phil,
>>
>> On 08/02/2019 21:02, Phil Race wrote:
>>> can you add
>>> @key headful
>>>
>>> to all these tests ?
>>
>> Yes, I can if you think it's required.
>
> Yes. I think it is required.

Please see the updated webrev:
http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/

These three test are not run in mach5.

Regards,
Alexey

>> <snip>
>>
>> I was thinking whether I shall add a diagnostic message for skipping 
>> VolatileImage when IndexColorModel is in effect…
>
> sure.
>
> -phil.
>
>>
>>
>> Regards,
>> Alexey
>>
>>>
>>> -phil.
>>>
>>> On 2/8/19 12:13 PM, Alexey Ivanov wrote:
>>>> Hi,
>>>>
>>>> Please review the fix for jdk 13:
>>>>
>>>> bugs:
>>>> https://bugs.openjdk.java.net/browse/JDK-8218682
>>>> https://bugs.openjdk.java.net/browse/JDK-8198411
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/
>>>>
>>>> Description:
>>>> The updated DashOffset test proved to fail in mach5.
>>>> It passed BufferedImage test and then failed VolatileImage test.
>>>>
>>>> VolatileImage had different colours instead of the expected white, 
>>>> blue and green.
>>>>
>>>> Root cause:
>>>> The host uses IndexColorModel; the image uses the closest colour.
>>>> Thus the colours do not match.
>>>>
>>>> It's also the reason why DashScaleMinWidth.java and 
>>>> DashZeroWidth.java fail in mach5.
>>>>
>>>> Fix:
>>>> Skip testing VolatileImage where default graphics configuration 
>>>> uses IndexColorModel.
>>>>
>>>> I'm removing DashScaleMinWidth.java and DashZeroWidth.java from 
>>>> ProblemList.txt as the tests pass now.
>>>>
>>>>
>>>> Regards,
>>>> Alexey