[OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

[Philip Race]

Unfortunately we can't check in the font.
That would require us to obtain a 3rd party code license and to update
the font regularly as new versions are created.
Way too onerous.

Perhaps instead you can just run through installed fonts ?

Can you also add a comment that explains that the values
you are using match those in freetype 2.6 -> current (2.9.1) ...

And consequently I think you should update the values used by 
OBLIQUE_MODIFIER
at the same time to match current freetype. The current value is from
the ancient 2.3 release. Include a comment there too ..

Also can you check you are keeping line lengths including comment
lines < 80 chars where possible ?

-phil.

On 2/12/19, 2:40 PM, Martin Balao wrote:
> Hi,
>
> I'd like to propose the following fix for "JDK-8218854:
> FontMetrics.getMaxAdvance may be less than the maximum
> FontMetrics.charWidth" [1]:
>
>   * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.00/
>
> Can I have a review?
>
> Thanks,
> Martin.-
>
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8218854