[OpenJDK 2D-Dev] RFR: 8216965 [JDK12] : crash in freetypeScaler.c CopyBW2Grey8

[Baesken, Matthias]

HI Phil, 
looks good to me and  fixes the issue seen on Solaris 11 and Suse Linux 15  (I am not a Reviewer however).
In the file :

http://cr.openjdk.java.net/~prr/8216965/src/java.desktop/share/native/libfontmanager/freetypeScaler.c.frames.html

you might update the Copyright year info .


I noticed that the return code handling of a few other freetype functions is not checked as well  at all call sites
( e.g.   FT_Done_FreeType,  FT_Reference_Face ).
I am not sure how critical this is , might be handled  in another CR .


Best regards, Matthias



> Message: 1
> Date: Fri, 18 Jan 2019 13:44:40 -0800
> From: Phil Race <philip.race at oracle.com>
> To: 2d-dev <2d-dev at openjdk.java.net>
> Subject: [OpenJDK 2D-Dev] RFR: 8216965 [JDK12] : crash in
> 	freetypeScaler.c	CopyBW2Grey8
> Message-ID: <32cebd31-b1c6-8a73-8452-30b98fb4305e at oracle.com>
> Content-Type: text/plain; charset="utf-8"; Format="flowed"
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216965
> Webrev: http://cr.openjdk.java.net/~prr/8216965/
> 
> Starting with JDK 12 b24 we are calling FT_Render_Glyph(..) but there's no
> check of an error return. Seems that on some very rare occasions
> freetype errors out on pt sz=1 so we need this check.
> 
> This fix is intended for JDK 12 so we don't ship with a new regression.
> 
> -phil