[OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

[Jayathirth Rao]

Hi Dmitry,

Thanks for the patch.
I can sponsor this.

I went through the change and it looks okay.
But I have a concern about using specific values for matrix based on Freetype version for Oblique type. I have less idea about that maybe Phil or others can clarify the same.

Regarding adding regression test along with the patch, i think we can use AWT Robot to get pixel data to verify the patch.

Thanks,
Jay

> On 18-Nov-2019, at 2:49 PM, Dmitry Batrak <dmitry.batrak at jetbrains.com> wrote:
> 
> Hello,
> 
> Still trying.
> Any volunteers to sponsor/review? 
> 
> Best regards,
> Dmitry Batrak
> 
> On Tue, Nov 5, 2019 at 11:27 AM Dmitry Batrak <dmitry.batrak at jetbrains.com <mailto:dmitry.batrak at jetbrains.com>> wrote:
> Hello,
> 
> Let me repeat the request.
> Any volunteers to sponsor/review? 
> 
> Best regards,
> Dmitry Batrak
> 
> ---------- Forwarded message ---------
> From: Dmitry Batrak <dmitry.batrak at jetbrains.com <mailto:dmitry.batrak at jetbrains.com>>
> Date: Thu, Aug 29, 2019 at 1:58 PM
> Subject: [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing
> To: 2d-dev <2d-dev at openjdk.java.net <mailto:2d-dev at openjdk.java.net>>
> 
> 
> Hello,
> 
> I'd like to submit a patch for JDK-8210058. I'm not a Committer, so I'll need someone to sponsor this change.
> 
> The issue is related to the implementation of algorithmic italics in FreeType font scaler. At the moment it uses FT_GlyphSlot_Oblique, but its implementation doesn't take into account the glyph transform, previously set using FT_Set_Transform, and FreeType developers don't seem to have any interest in changing that (see https://savannah.nongnu.org/bugs/index.php?54565 <https://savannah.nongnu.org/bugs/index.php?54565>).
> The proposed solution is to include corresponding shear transform explicitly in matrix passed to FT_Set_Transform instead of using FT_GlyphSlot_Oblique.
> Proposed patch doesn't add any tests, as the change only impacts glyph rendering, and I couldn't think of a reliable way to test that automatically. Existing automated tests from OpenJDK pass after the fix.
> 
> Issue:  https://bugs.openjdk.java.net/browse/JDK-8210058 <https://bugs.openjdk.java.net/browse/JDK-8210058>
> Webrev: http://cr.openjdk.java.net/~dbatrak/8210058/webrev.00/ <http://cr.openjdk.java.net/~dbatrak/8210058/webrev.00/>
> 
> Best regards,
> Dmitry Batrak
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20191118/7d7abf65/attachment-0001.html>