[OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check return value of SurfaceData_InitOps on macosx

Langer, Christoph christoph.langer at sap.com
Wed Nov 20 14:19:39 UTC 2019


Hi Matthias,

looks good and trivial to me.

Cheers
Christoph

From: 2d-dev <2d-dev-bounces at openjdk.java.net> On Behalf Of Baesken, Matthias
Sent: Dienstag, 19. November 2019 15:07
To: 2d-dev at openjdk.java.net
Subject: [CAUTION] Re: [OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check return value of SurfaceData_InitOps on macosx

Small update - I had to add an inclusion, new webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.1/

Best regards, Matthias


Hello,  please review this small  macos  related fix .

In the java.desktop coding, at most usages of SurfaceData_InitOps the return value of the function is NULL-checked to avoid crashes in seldom cases where  the function  SurfaceData_InitOps  returns NULL.
However in the macos related coding this is missing at some places.


Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8234323

http://cr.openjdk.java.net/~mbaesken/webrevs/8234323.0/


Thanks, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20191120/76d7f2b8/attachment.html>


More information about the 2d-dev mailing list