[OpenJDK 2D-Dev] build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

[Baesken, Matthias]

Hello,  any comments on the issue ?

Could we maybe switch from using

NSTextInputSourceIdentifier

to

String  (NSString* ?)   , because     https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier

says  NSTextInputSourceIdentifier    is a typealias for String  ?

Best regards ,Matthias




Hello, I noticed  that since today our  jdk/jdk  build fails on macOS . We run it on macOS 10.12 .

It seems
https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33

8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

Brought a  dependency on 10.13.  Was that intended ? Could we keep 10.12  compatibility ?
At least  the doc of  NSTextInputSourceIdentifier  :   https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
mentions  macOS 10.13+  .



Build errors are :
----------------------------

/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: error: unknown type name 'NSTextInputSourceIdentifier'
    NSTextInputSourceIdentifier kbdLayout;
    ^
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: error: assignment to readonly property
        self.cglLayer = windowLayer;
        ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: error: assignment to readonly property
    self.cglLayer = nil;
    ~~~~~~~~~~~~~ ^ ~~~
3 errors generated.


...
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: error: incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed char') with an expression of type 'id' [-Werror,-Wint-conversion]
            BOOL mouseIsOver = [[window contentView] mouseIsOver];
                 ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.



Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20191125/c35b8cc0/attachment.html>