[OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java does not render Myanmar script correctly

[Sergey Bylokhov]

+1

On 10/14/19 4:57 am, Alexey Ivanov wrote:
> Thank you, Phil, for your review.
> I'm still looking for a second reviewer. Any volunteers, please?
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8223558
> webrev: http://cr.openjdk.java.net/~aivanov/8223558/webrev.00/
> 
> Thank you in advance.
> 
> On 07/10/2019 16:51, Phil Race wrote:
>> sounds good.
>>
>> -phil.
>>
>> On 10/7/19 5:07 AM, Alexey Ivanov wrote:
>>> Hi Phil,
>>>
>>> Thank you for your review.
>>> I have updated the summary of the bug to be more specific: “Java does not render Myanmar script correctly”.
>>>
>>> This fix addresses only the rendering of Myanmar characters. Adding Myanmar script and related languages to the list of supported locales is premature at this point.
>>>
>>> No input method is required. One just types characters one by one; the correct positioning of the glyphs is highly dependent software support and the fonts. With this fix, it should work reasonably well.
>>>
>>> Regards,
>>> Alexey
>>>
>>> On 04/10/2019 21:13, Phil Race wrote:
>>>> The code changes look fine, but  nothing you are doing here makes Myanmar "supported".
>>>> It may work reasonably well, but it does not get added to the list of supported locales - for Oracle JDK anyway.
>>>> Also I don't know what input method support might be required for this besides what
>>>> you are doing here on the display side.
>>>>
>>>>
>>>> -phil.
>>>>
>>>>
>>>> On 10/3/19 10:28 AM, Alexey Ivanov wrote:
>>>>> Hi Phil,
>>>>>
>>>>> Thank you for your review.
>>>>> Please see my answers inline:
>>>>>
>>>>> On 03/10/2019 17:31, Philip Race wrote:
>>>>>> 1) This is an RFE, not a bug.
>>>>>
>>>>> I have updated the CR type to RFE.
>>>>>
>>>>>> 2) Does this font exist on Windows 7 ?
>>>>>
>>>>> No, it does not. This font was added in Windows 8.
>>>>> https://docs.microsoft.com/en-us/typography/font-list/myanmar-text
>>>>>
>>>>> The tests check if the required font is available; if not, an message is printed and the test exists.
>>>>>
>>>>>> 3) This cannot be backported since the older JDK releases will not support it.
>>>>>
>>>>> No, it cannot be backported to 8u because ICU does not support Myanmar.
>>>>> It can be brought to 11 updates.
>>>>>
>>>>>
>>>>> Regards,
>>>>> Alexey
>>>>>>
>>>>>>
>>>>>> -phil.
>>>>>>
>>>>>>
>>>>>> On 10/3/19, 8:57 AM, Alexey Ivanov wrote:
>>>>>>> Any volunteers to review?
>>>>>>>
>>>>>>> On 25/09/2019 20:38, Alexey Ivanov wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Please review the fix for JDK 14:
>>>>>>>>
>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8223558
>>>>>>>> webrev: http://cr.openjdk.java.net/~aivanov/8223558/webrev.00/
>>>>>>>>
>>>>>>>> Problem description:
>>>>>>>> Java renders Myanmar script incorrectly. Some glyphs are not combined, which makes text unreadable.
>>>>>>>> For example, this glyph ကြ is made of two characters U+1000 and U+103C. Java renders two separate glyphs.
>>>>>>>>
>>>>>>>> Workaround:
>>>>>>>> Enable ligatures or kerning on the font to get the correct rendering.
>>>>>>>>
>>>>>>>> The fix:
>>>>>>>> Enables complex layout for base Myanmar characters (U+1000-U+109F).
>>>>>>>> Provides fallback font on Windows.
>>>>>>>> On Linux, fontconfig handles the fallback.
>>>>>>>>
>>>>>>>> I ran awt/font tests, no new failures found.
>>>>>>>>


-- 
Best regards, Sergey.