[OpenJDK 2D-Dev] <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

[Baesken, Matthias]

Hi Christoph,  thanks for the review and further cleanup !

> Would be good if somebody from 2D could review this, though.

I agree !

Best regards, Matthias


From: Langer, Christoph <christoph.langer at sap.com>
Sent: Freitag, 6. September 2019 15:42
To: Baesken, Matthias <matthias.baesken at sap.com>; 2d-dev at openjdk.java.net
Subject: RE: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

Hi Matthias,

I checked your RFR and it looks ok. I have some minor suggestions and spotted some further room for cleanup in FcFontConfiguration.java. I've taken your code, added my modifications and prepared a new webrev.

http://cr.openjdk.java.net/~clanger/webrevs/8227441.0/

Would be good if somebody from 2D could review this, though.

Thanks
Christoph

From: 2d-dev <2d-dev-bounces at openjdk.java.net<mailto:2d-dev-bounces at openjdk.java.net>> On Behalf Of Baesken, Matthias
Sent: Dienstag, 16. Juli 2019 17:09
To: 2d-dev at openjdk.java.net<mailto:2d-dev at openjdk.java.net>
Subject: [CAUTION] Re: [OpenJDK 2D-Dev] <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

Ping ,  any comments on this one ?

Thanks, Matthias

From: Baesken, Matthias
Sent: Mittwoch, 10. Juli 2019 08:49
To: 2d-dev at openjdk.java.net<mailto:2d-dev at openjdk.java.net>
Cc: Phil Race (philip.race at oracle.com<mailto:philip.race at oracle.com>) <philip.race at oracle.com<mailto:philip.race at oracle.com>>
Subject: FW: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

>Before I, or anyone else, starts to look at or comment on this,
>can you instead post to the correct list : 2d-dev.

Sure!

Best regards, Matthias

From: Philip Race <philip.race at oracle.com<mailto:philip.race at oracle.com>>
Sent: Dienstag, 9. Juli 2019 17:26
To: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Cc: awt-dev at openjdk.java.net<mailto:awt-dev at openjdk.java.net>
Subject: Re: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file

Hi,

Before I, or anyone else, starts to look at or comment on this,
can you instead post to the correct list : 2d-dev.

-phil.

On 7/9/19, 7:21 AM, Baesken, Matthias wrote:
Hello,  please review this small  change that enhances logging a bit .

When reading the fcinfo - file (fontconfig info file) we currently have very limited logging.
This should be enhanced to get more info in case of errors , and to have at least some info in the log when -Dsun.java2d.debugfonts=true is set.

Currently the logging   writes  a ton of info  about lots of non-existant  files , but misses the fcinfo file .

Example output , we run here with  -Dsun.java2d.debugfonts=true   set   :   (with my  added   "successfully parsed the fontconfig file at ..."  from the patch  )

  ...
INFO: Creating standard Font Configuration
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.4.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.4.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.4.12.14-25.25-default.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.4.12.14-25.25-default.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.4.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.4.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.properties
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl
INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.bfc
Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findFontConfigFile
INFO: Did not find a fontconfig file.
Jul 09, 2019 3:36:59 PM sun.font.FcFontConfiguration readFcInfo
INFO: successfully parsed the fontconfig file at /myhomedir/user/.java/fonts/14.0.0.1-internal/fcinfo-1-thismachine-Linux-4.12.14-25.25-default-en-US.properties



Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8227441

http://cr.openjdk.java.net/~mbaesken/webrevs/8227441.0/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8227441.0/>

Thanks, Matthias


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20190909/2486e0c1/attachment-0001.html>