[OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform has flip bit

[Jayathirth Rao]

+1.

Thanks,
Jay

> On 10-Sep-2019, at 3:18 AM, Phil Race <philip.race at oracle.com> wrote:
> 
> Approved.
> 
> -phil.
> 
> On 9/6/19 2:15 PM, Laurent Bourgès wrote:
>> Hi,
>> 
>> Please review this bug fix for the Marlin renderer (present in Pisces code since JDK 6?):
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8230728 <https://bugs.openjdk.java.net/browse/JDK-8230728>
>> webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/ <http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/>
>> 
>> This patch fixes a NaN handling in userSpaceLineWidth() when the affine transform determinant is negative (flip bit is ON)
>> 
>> Changes:
>> - MarlinRenderingEngine: use abs(at.getDeterminant()) to ensure positive value before using sqrt
>> - FlipBitTest: new jtreg test reproducing the original problem drawing a thin ellipse with a flipped transform
>> 
>> Cheers,
>> Laurent
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20190910/64f856ff/attachment.html>