[OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return

Baesken, Matthias matthias.baesken at sap.com
Tue Sep 10 06:46:59 UTC 2019


Hi Phil , I just had a look at a lot of  GetPrimitiveArrayCritical   calls  in the jdk codebase .
Thanks for the review .
Best regards, Matthias


From: Phil Race <philip.race at oracle.com>
Sent: Montag, 9. September 2019 17:55
To: Baesken, Matthias <matthias.baesken at sap.com>; 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR [XS] 8230769: BufImg_SetupICM add ReleasePrimitiveArrayCritical call in early return

Looks good to me. How did you spot this ? The error code path is unlikely to be taken
so checking for JNI warnings presumably won't report it.

-phil
On 9/9/19 7:49 AM, Baesken, Matthias wrote:
Hello,   please review  the following  webrev .

I noticed that  in function  BufImg_SetupICM, in case of initCubemap returning NULL we currently miss a ReleasePrimitiveArrayCritical call;
this should be added.

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8230769

http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/


Thanks, Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20190910/0420e0f5/attachment.html>


More information about the 2d-dev mailing list