[OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Wed Apr 1 08:17:14 UTC 2020

On 01-Apr-20 3:51 AM, Sergey Bylokhov wrote:
> Hi, Prasanta.
> On 3/30/20 7:46 am, Prasanta Sadhukhan wrote:
>> I guess it is better if you directly pass NULL to OpenPrinter, rather 
>> than create an unnecessary variable.
> That was done only for documentation purposes.
>> Also, I think it will be good if we do a ClosePrinter() if 
>> FindFirstPrinterChangeNotification() fails.
> Nice catch! webrev is updated:
> http://cr.openjdk.java.net/~serb/8241829/webrev.01

Looks good now. But since this is a cleanup exercise, I would have liked 
to remove the unnecessary variable and still keep the documentation, 
can't we (like "NULL in 1st argument indicates using local printer 
server")? but anyway, not a dealbreaker, upto you.

>> Regards
>> Prasanta
>> On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk/client.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241829
>>> Fix: http://cr.openjdk.java.net/~serb/8241829/webrev.00
>>> In PrintServiceLookupProvider.java we always pass NULL to
>>> the notifyFirstPrinterChange as a name of the printer, so
>>> we can remove the code which expects a non-null value.

More information about the 2d-dev mailing list