[OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

Alexey Ivanov alexey.ivanov at oracle.com
Thu Apr 2 17:51:36 UTC 2020


On 02/04/2020 03:56, Sergey Bylokhov wrote:
> On 4/1/20 7:38 am, Alexey Ivanov wrote:
>> I agree, I'd remove printerName local variable. You can modify the 
>> original comment:
>>
>>       // If pPrinterName (the first parameter) is NULL, "it indicates 
>> the local printer server" - MSDN.
>
> But that tooo long, I mean the short comment to the local var is much 
> shorter.

What about this?

// Open the local printer server
BOOL ret = OpenPrinter(NULL, &hPrinter, NULL);

Concise and clear.
For details and to look up the meaning of the parameters, if required, 
one can always open MSDN.

-- 
Regards,
Alexey


More information about the 2d-dev mailing list