[OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

[Mario Torre]

It seems good to me. I also like that you mention actual examples, it
will make life a bit easier when trying to understand why things don't
seem to work as expected, so the actual text works for me, there's a
couple of places where you have double spaces that you may want to
fix, for example a "characters are  mapped into glyphs" and a dangling
space after "the baseline.".

Cheers,
Mario

On Wed, Apr 22, 2020 at 9:51 PM Philip Race <philip.race at oracle.com> wrote:
>
> bug : https://bugs.openjdk.java.net/browse/JDK-8230672
> webrev : http://cr.openjdk.java.net/~prr/8230672/
>
> Loosen up the spec. a lot to reflect reality.
>
> I considered deprecating the method but there isn't any easy replacement,
> so it would just be annoying to old code.
>
> This will clearly need a CSR which I will draft once we agree on the
> text here.
>
> -phil.
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898