[OpenJDK 2D-Dev] RFR: 8221305: java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Apr 29 21:21:27 UTC 2020


On 4/28/20 4:28 pm, Philip Race wrote:
>>> And max advance is NOT only about the advance of the first 256 characters anyway
>> Yes but it makes it a little bit more useful, it least it will always return correct max
>> advance for the first characters.
> 
> Actually I'll argue it can be the opposite.
> Doing this you ask it to go check in fallback fonts and in the failure I
> analysed on macos we got a fallback from a CJK font for an unprintable character.
> Now whilst that may make it "more likely" if we include that in the maxadvance
> and care only about chars 0-255 it will pass, you've now got a very different max
> advance returned than is the design centre for the primary font and REAL uses
> of chars 0-255 which would never try to display char 132 etc.

Then probably we could skip any unprintable characters?

-- 
Best regards, Sergey.


More information about the 2d-dev mailing list