[OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

Alexey Ivanov alexey.ivanov at oracle.com
Wed Aug 19 22:03:15 UTC 2020


Looks good.

Regards,
Alexey

On 18/08/2020 15:23, Kumar Abhishek wrote:
> Hi Alexey,
>
> Please find the updated Webrev link here:- http://cr.openjdk.java.net/~arapte/Abhishek/8200281/webrev.05
> I have updated the missed annotation.
>
>
> Thanks,
> Abhishek
> -----Original Message-----
> From: Alexey Ivanov
> Sent: Tuesday, August 18, 2020 2:26 AM
> To: Kumar Abhishek <kumar.z.abhishek at oracle.com>
> Cc: Dmitry Markov <dmitry.markov at oracle.com>; Philip Race <philip.race at oracle.com>; 2d-dev <2d-dev at openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins
>
> Hi Abhishek,
>
> We're getting closer but some annotations from those I listed in my previous email are still missing:
>
> *BMPImageReader.java*
>
> 2067                 public Boolean run() {
>
>
> *JPEGImageReader.java*
>
> 954                     protected ImageTypeSpecifier produce() {
>
>
> *TIFFImageWriter.java*
>
> I also found one more missing @Override:
> 3687     public Raster getTile(int tileX, int tileY) {
>
>
> *WBMPImageReader.java*
>
> Shall we also sort the imports? I mean move:
>     43 import java.io.IOException;
>     44 import java.util.ArrayList;
>     45 import java.util.Iterator;
> to be after
>     33 import java.awt.image.WritableRaster;
>
> Though It's fine with me as is.
>
>
> Regards,
> Alexey
>
> <SNIP>


More information about the 2d-dev mailing list