[OpenJDK 2D-Dev] RFR: 8238842: AIOOBE in GIFImageReader.initializeStringTable

[Brian Burkhalter]

> On Feb 12, 2020, at 11:25 AM, Phil Race <philip.race at oracle.com> wrote:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238842 <https://bugs.openjdk.java.net/browse/JDK-8238842>
> Webrev: http://cr.openjdk.java.net/~prr/8238842/ <http://cr.openjdk.java.net/~prr/8238842/>
> 
> The string table has a maximum size of 4096 - by GIF spec as well as in the implementation
> The value initCodeSize (as a power of 2) to initialise the string table, and since GIF
> only allows 8bpp, this ought to max out at 256.
> 
> But there's no check so we can get an ArrayIndexOutOfBoundsException
> This is now checked for.

Looks good.

> Also I removed a printStackTrace which briefly confused me during debugging
> as I had no idea where the message was coming from.

I saw.

> See the bug for more details.

I assume the test fails without the source change.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200212/f4c1a222/attachment.htm>