[OpenJDK 2D-Dev] RFR [XS]: 8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java fails in SunFontManager.findFont2D

[Jayathirth D v]

Looks good to me.

Thanks,
Jay

> On 01-Jul-2020, at 12:10 PM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
> Ping …  would be nice to get a review …
>  
> From: Baesken, Matthias 
> Sent: Montag, 29. Juni 2020 10:06
> To: 2d-dev at openjdk.java.net <mailto:2d-dev at openjdk.java.net>
> Subject: RFR [XS]: 8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java fails in SunFontManager.findFont2D
>  
> Hello, please review this small fix.
>  
> It was noticed that the jtreg test java/awt/font/DefaultFontTest/DefaultFontTest.java fails on one of our RedHat 7.1 machines with this exception :
> 
> java.lang.NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because "name" is null
> at java.desktop/sun.font.SunFontManager.findFont2D(SunFontManager.java:1891)
> at java.desktop/sun.font.SunFontManager.getDefaultPhysicalFont(SunFontManager.java:1036)
> at DefaultFontTest.main(DefaultFontTest.java:57)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> at java.base/java.lang.Thread.run(Thread.java:832)
> 
> 
> Looks like name.toLowerCase(Locale.ENGLISH); is called on a  font name  that is null, this should be checked / avoided .
>  
>  
>  
> Bug/webrev :
>  
> https://bugs.openjdk.java.net/browse/JDK-8248468 <https://bugs.openjdk.java.net/browse/JDK-8248468>
>  
> http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/ <http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/>
>  
>  
> Thanks, Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200701/d44618ce/attachment.htm>