[OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

[Baesken, Matthias]

Thank‘s  for the review !
May I get a second  review ?


Best regards, Matthias



From: Jayathirth D v <JAYATHIRTH.D.V at ORACLE.COM>
Sent: Donnerstag, 9. Juli 2020 07:21
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

Looks good to me.

Thanks,
Jay


On 06-Jul-2020, at 12:43 PM, Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:

Hello, please review this small change to font related logging .

We have a lot of font logging calls in java.desktop that look similar to this coding :

        if (FontUtilities.isLogging()) {
            FontUtilities.getLogger().info("Here comes my important info");
        }

This coding could be simplified by adding static log methods to FontUtilities.java

public static void logWarning(String s);
public static void logInfo(String s);
public static void logSevere(String s);

  doing the isLogging check + FontUtilities.getLogger(). …



Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8248802

http://cr.openjdk.java.net/~mbaesken/webrevs/8248802.0/


Thanks, Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200709/622e3e2b/attachment-0001.htm>