[OpenJDK 2D-Dev] [16] RFR JDK-8243674: Remove language tag length limit for iTXt chunk in PNGImageReader

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Jul 30 22:55:03 UTC 2020


Hi, Jay.

The fix looks fine, but maybe we can to trigger added IIOException(remainingLen < 0) by the test?

On 29.07.2020 02:41, Jayathirth D v wrote:
> Hello All,
> 
> Please review the following fix for JDK 16:
> 
> Bug : https://bugs.openjdk.java.net/browse/JDK-8243674
> Webrev : http://cr.openjdk.java.net/~jdv/8243674/webrev.00/
> 
> Issue : We have language tag length limit of 80 for iTXt chunk in PNGImageReader which is not spec compliant(http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.iTXt). There should not be limit on length of language tag.
> Solution : Remove language tag restriction of 80. In PNGImageWriter we don’t enforce any limit on language tag length.
> 
> Thanks,
> Jay


-- 
Best regards, Sergey.


More information about the 2d-dev mailing list