[OpenJDK 2D-Dev] <AWT Dev> RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

[Pankaj Bansal]

Hi Toshio,

I will commit this for you.

Regards,

Pankaj


On 06/03/20 6:10 AM, Toshio 5 Nakamura wrote:
>
> Hi Sergey, Prasanta, Pankaj,
>
> Thank you for the review. May I ask a sponsor of the fix as well?
> I'm not a committer.
>
> Best Regards,
> Toshio Nakamura
>
> Pankaj Bansal <pankaj.b.bansal at oracle.com> wrote on 2020/03/05 18:22:43:
>
> > From: Pankaj Bansal <pankaj.b.bansal at oracle.com>
> > To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, awt-
> > dev at openjdk.java.net, 2d-dev <2d-dev at openjdk.java.net>
> > Date: 2020/03/05 18:22
> > Subject: [EXTERNAL] RE: <AWT Dev> RFR: 8240518: Incorrect
> > JNU_ReleaseStringPlatformChars in Windows Print
> >
> > Looks good to me
> >
> > -Pankaj
> >
> > -----Original Message-----
> > From: Sergey Bylokhov
> > Sent: Thursday, March 5, 2020 2:35 PM
> > To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>; awt-
> > dev at openjdk.java.net; 2d-dev <2d-dev at openjdk.java.net>
> > Subject: Re: <AWT Dev> RFR: 8240518: Incorrect
> > JNU_ReleaseStringPlatformChars in Windows Print
> >
> > (CC) 2d-dev,
> >
> > Looks fine.
> >
> > On 3/4/20 4:48 am, Toshio 5 Nakamura wrote:
> > > Hi,
> > >
> > > I'd like to ask review and sponsor of this fix.
> > >
> > > Issue: https://bugs.openjdk.java.net/browse/JDK-8240518
> > > Fix: http://cr.openjdk.java.net/~tnakamura/8240518/webrev.00 
> <http://cr.openjdk.java.net/%7Etnakamura/8240518/webrev.00>
> > >
> > > Eclipse OpenJ9 VM detects two errors about
> > JNU_ReleaseStringPlatformChars in WPrinterJob.cpp.
> > > Then, I checked similar situation in the folder, and found one
> > lacking of the release method in awt_PrintControl.cpp.
> > >
> > > Best regards,
> > >
> > > Toshio Nakamura
> > >
> >
> >
> > --
> > Best regards, Sergey.
> >
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200306/1a466915/attachment-0001.htm>