[OpenJDK 2D-Dev] [15] Review Request: 8238075 [OGL] Delete unused properties

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Mar 9 22:14:05 UTC 2020


Any volunteers to review? =)

On 1/28/20 8:15 pm, Sergey Bylokhov wrote:
> Hello.
> Please review the small cleanup for JDK 15.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238075
> Fix: http://cr.openjdk.java.net/~serb/8238075/webrev.00
> 
> The OGL pipeline on macOS still used some properties:
>   - CGLGraphicsConfig#kOpenGLSwapInterval is not useful since we moved to the CALayer
>   - CGLGraphicsConfig#pixfmt never used
>   - Initialization of CGLGraphicsConfig does not depend on displayID after JDK-8223158[1]
> 
> Also I simplified the native initialization logic of CGLGraphicsConfig.
> Previously we create an array of parameters and passed them to the selector, also we
> return result via the same array, in the fix selector was replaced by the simple "block"
> passed to "ThreadUtilities performOnMainThreadWaiting"
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8223158
> 


-- 
Best regards, Sergey.


More information about the 2d-dev mailing list