[OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

Sergey Bylokhov serb at openjdk.java.net
Thu Nov 5 11:26:57 UTC 2020


On Mon, 2 Nov 2020 16:23:19 GMT, Phil Race <prr at openjdk.org> wrote:

>> I'm just a bit curious about the added, empty, `src/java.desktop/share/native/libharfbuzz/abc.txt`...
>> 
>> If it really is in upstream source, I'm not saying you should remove it. It just looks very odd. It's not a merge artifact?
>> 
>> (I could not even add review comments to an empty file in github!  ��)
>
>> I'm just a bit curious about the added, empty, `src/java.desktop/share/native/libharfbuzz/abc.txt`...
>> 
>> If it really is in upstream source, I'm not saying you should remove it. It just looks very odd. It's not a merge artifact?
>> 
>> (I could not even add review comments to an empty file in github! ��)
> 
> oops. that should not have been in that folder. It was me practicing a different white space removal script.
> I thought I checked for any extraneous files. I'll get rid of it now.

Looks like the build on macOS via GitHub will be broken by this fix?

-------------

PR: https://git.openjdk.java.net/jdk/pull/993


More information about the 2d-dev mailing list